Self-Review Checklist
Run through every item before reporting task as complete.
Code quality
- •
uv run ruff check --fix— zero warnings, nonoqacomments added - •
uv run ruff format— no formatting changes - •
uv run pytest— all pass, coverage >= 85%
Conventions
- •Stdlib imports:
import datetime,import typing— module style, notfrom - •Constants: magic strings use
src/const.py, accessed asconst.X - •No circular import hacks (no local imports inside functions for dependency resolution)
- •DDD structure: each domain module has router/schemas/models/service/dependencies/exceptions
User-facing
- •User-facing strings use localization (all 4 languages), not hardcoded
- •Documentation updated: README + localized READMEs, ADMIN.md if needed
Security
- •No secrets/tokens in logs, responses, or error messages
- •Input validated via Pydantic before use
- •Auth checks on all endpoints
- •Rate limits on new public endpoints
Summary
- •Run
git diff --stat— list all changed files, verify diff under ~500 lines
Report pass/fail for each item.