epic-hygiene-process

// BEFORE (Violation)
import { saveTopic } from '@/core/db.js'; // View importing DB

export default class QuizView extends BaseView {
  async handleSave() {
    await saveTopic(this.topic); // Direct DB access
  }
}

// AFTER (Compliant)
import { quizService } from '@/services/quiz-service.js'; // Use service layer

export default class QuizView extends BaseView {
  async handleSave() {
    await quizService.saveTopic(this.topic); // Service handles DB
  }
}

# Check current architecture compliance
npm run arch:test

# Generate dependency graph for visualization
npm run arch:graph

# Convert to image (requires dot)
dot -Tpng dependency-graph.dot -o architecture.png

// BEFORE (Inefficient)
export function processItems(items) {
  let result = [];
  for (let i = 0; i < items.length; i++) {
    result.push(transform(items[i]));
  }
  return result;
}

// AFTER (Optimized)
export function processItems(items) {
  return items.map(transform); // Built-in, faster
}

// BEFORE (Legacy)
function fetchData() {
  return fetch('/api/data')
    .then(response => response.json())
    .catch(error => {
      console.error('Failed:', error);
      throw new Error('API error');
    });
}

// AFTER (Standardized)
import { logger } from '@/utils/logger.js';
import { handleApiError } from '@/utils/errorHandler.js';

export async function fetchData() {
  try {
    const response = await fetch('/api/data');
    return await response.json();
  } catch (error) {
    logger.error('API fetch failed', { endpoint: '/api/data', error });
    throw new Error(handleApiError(error));
  }
}

# Create task-specific branch
git checkout -b hygiene/[task-description]

# Create learning notes file
touch docs/learning/epic10_hygiene/PHASE*_TASK_DESCRIPTION_NOTES.md

# Make one logical change
# Test it works
git add .
git commit -m "type(scope): description"

# Repeat for each change

# Prefixes:
refactor(hygiene): Code refactoring without behavior change
test(hygiene): Test updates for hygiene task
docs(hygiene): Documentation updates
chore(hygiene): Build/config changes
perf(hygiene): Performance improvements

# Examples:
refactor(hygiene): remove unused utility functions
test(hygiene): update tests after dead code removal
docs(hygiene): document architecture compliance fixes
perf(hygiene): optimize data processing functions

# Unit tests
npm test

# Type checking
npm run typecheck

# Architecture validation
npm run arch:test

# Dead code detection
npm run lint:dead-code

# E2E tests (if UI changes)
npm run test:e2e

# Run mutation testing on affected files
npx stryker run --mutate "src/core/state.js"

# Target: >75% mutation score

# Task: [Task Description]

**Date:** YYYY-MM-DD
**Type:** [dead-code-removal|architecture-compliance|performance|standardization]
**Effort:** X sessions

## Objective
Brief description of what the task accomplished.

## What Was Changed
- [ ] Files removed: [list]
- [ ] Files modified: [list]
- [ ] Dependencies removed: [list]
- [ ] Tests updated: [list]

## Problems Encountered
1. **Problem**: Description
   **Solution**: How solved
   **Learning**: What to avoid in future

## Results
- Lines of code removed: [number]
- Mutation score improvement: [before] → [after]
- Architecture violations fixed: [number]
- Test coverage impact: [before] → [after]

## Process Improvements
- What worked well
- What could be improved
- Tools or scripts that would help next time

## Before/After Metrics
| Metric | Before | After |
|--------|--------|--------|
| Bundle size | X kb | Y kb |
| Test coverage | X% | Y% |
| Mutation score | X% | Y% |
| Architecture violations | X | Y |

### Completed Tasks

| Task | Completed | Document |
|------|-----------|----------|
| [Task Description] | YYYY-MM-DD | [PHASE*_TASK_NOTES.md](./PHASE*_TASK_NOTES.md) |

# Complete test suite
npm test -- --run

# Full architecture check
npm run arch:test

# Type checking
npm run typecheck

# Dead code check (should find none new)
npm run lint:dead-code

# Build verification
npm run build

# Find unused dependencies
npm ls | grep "unused"

# Remove unused dependency
npm uninstall package-name

# Update package-lock.json
npm install

// BEFORE (Mixed imports)
import { func1 } from './utils.js';
import something from 'external-lib';
import { func2 } from './utils.js';

// AFTER (Grouped imports)
import { func1, func2 } from './utils.js';
import something from 'external-lib';

// BEFORE (Inconsistent)
if (error) {
  console.log('Error:', error.message);
  return null;
}

// AFTER (Standardized)
if (error) {
  logger.error('Operation failed', { error: error.message });
  return null;
}

# Find debugging statements
grep -r "console.log\|debugger\|alert" src/ --include="*.js"

# Remove them (be careful!)
# Verify no functionality is lost

# Emergency rollback (if worktree still exists)
cd ../saberloop-hygiene
git reset --hard HEAD~1  # Undo last commit

# Full rollback (if merged to main)
cd ../demo-pwa-app  # Main repo
git revert main  # Creates revert commit
git push origin main  # Push revert

# Process in logical order
1. Dead code removal (cleanest slate)
2. Architecture compliance (structural)
3. Performance optimization (last)
4. Code standardization (final polish)