GitHub PR workflow
Non-negotiables
- •Code quality is sacred.
- •Commit history is part of the deliverable. Keep it clean.
- •Treat warnings seriously.
When creating a PR
- •Ensure we are on a properly named branch (see
git+git-workflowskills). - •Gather context:
- •
git status,git diff,git log --oneline
- •
- •Ensure branch is pushed (ask before pushing if uncertain).
- •PR title must follow Conventional Commit format:
<type>(<scope>): <desc>. - •PR description must be minimal and human:
- •Check for a PR template under
.github/(if it exists, fill it). - •Otherwise use short bullets and short sentences.
- •Mention key design decisions and any plan changes.
- •Link ticket if available.
- •Check for a PR template under
- •Draft title/body following the
communicationskill. - •Create PR with
gh pr create. - •Return the PR URL.
When reviewing a PR
- •Gather context:
- •
gh pr view(title/body/base/head) - •
gh pr diff - •
gh pr checks
- •
- •Apply
code-reviewstandards (and/or delegate analysis to thecode-reviewersubagent for a structured handoff). - •Summarize:
- •top risks
- •must-fix vs should-fix
- •test gaps
- •Do not post comments unless explicitly asked.
Review output style
- •If asked to draft comments, follow the
communicationskill.