AgentSkillsCN

Review Followup

回顾后续

SKILL.md

Review Follow-up Skill

Use this skill when the user says a PR review has been done and asks to process reviewer comments.

Goal

Process GitHub PR review comments end-to-end:

  1. fetch review threads/comments,
  2. assess validity,
  3. implement fixes when appropriate,
  4. push changes,
  5. resolve addressed threads.

Workflow

  1. Identify current branch and linked open PR.
  2. After creating/updating the PR, wait 60 seconds before the first status check.
  3. Poll every 60 seconds for Copilot review with this policy:
    • maximum wait window: 20 minutes,
    • stop waiting immediately when Copilot review is present,
    • do not wait the full 20 minutes if review arrives earlier.
  4. Check CI status independently and ensure checks are completed/passing before merge.
  5. Fetch review threads with:
    • python3 /Users/g1lom/.codex/skills/gh-address-comments/scripts/fetch_comments.py
  6. Build a short numbered list of threads with:
    • issue summary,
    • validity assessment (valid, partially valid, not needed),
    • intended action.
  7. Analyze Copilot comments and act according to relevance:
    • implement fixes for valid,
    • implement minimal safe adjustments for partially valid,
    • do not implement not needed and document rationale in PR discussion.
  8. For each review thread, post a follow-up comment that states:
    • what change resolved it, or
    • why it was not implemented.
  9. Apply code/test/documentation fixes for valid items.
  10. Run quality gates:
  • uv run ruff check .
  • uv run ty check src tests
  • uv run pytest -m unit
  • uv run pytest -m integration
  • uv run pytest -m end2end
  1. Commit and push.
  2. Resolve threads for addressed comments via GraphQL mutation resolveReviewThread, only after the follow-up comment is posted.
  3. Report what was fixed, which threads were resolved, and what was intentionally not changed.

Thread resolution note

Only resolve a thread when:

  • code or docs were actually updated to address it, or
  • a clear rationale is provided in PR discussion for rejecting it.
  • and the thread contains a final follow-up comment summarizing the resolution status.