AgentSkillsCN

quality-gate

提交前必须通过最终质量门:确保所有检查项均达标(构建/格式化/静态分析/测试),同时全面审视代码的可读性、模块化程度、边界划分以及错误处理路径。依据具体 checklist 完成必要的自审工作。

SKILL.md
--- frontmatter
name: quality-gate
description: "MANDATORY final gate before submission: make checks all green (build/format/static-analysis/tests) and review readability, modularity, boundaries, and error paths. Produce the required self-review with concrete checklists."
metadata:
  short-description: Final quality gate

Purpose

Use this skill as the last step before submitting a change.

It combines two things:

  1. verification (build/format/static-analysis/tests)
  2. a structured review against this repo’s standards

When to use

Invoke this skill before every submission. It is mandatory.

How to use

  1. Open references/quality-gate.md and run the checklist.

  2. Run the canonical commands for build / format / static analysis / tests.

    • If a command cannot be run, explain why and provide a reproducible procedure.
  3. Review the diff with the checklists:

    • Readability (naming, comments, control flow, tests)
    • Modularity / coupling / boundaries (worst-level rating)
    • Boundary error handling (translation, no swallowed failures)
    • Concurrency (plan, shutdown/cancellation, observability, verification)
    • Observability (logs/metrics/traces for runtime behavior changes)
    • Documentation (requirements / acceptance criteria / verification method)
  4. If you changed C++:

    • .hpp: verify Doxygen completeness for all declarations (including private).
    • .cpp: verify intent-first comments and a magic-value audit.
  5. Fix findings and repeat until 0 findings remain.

Output expectation

  • Output “0 findings” only when checks and checklist are fully satisfied.
  • Otherwise, list each finding with: location, why it matters, and the concrete fix applied (or the reason it remains).