AgentSkillsCN

code-review-criteria

代码评审标准涵盖代码质量、最佳实践、Bug 修复、性能优化，以及安全考量。这些标准由代码评审与修复代理共同执行。

SKILL.md
--- frontmatter
name: code-review-criteria
description: "Code review criteria covering code quality, best practices, bugs, performance, and security concerns. Applied by code review and fix agents."
user-invocable: false

Review Criteria

Review code changes and provide feedback on:

  • •Code quality and best practices
  • •Potential bugs or issues
  • •Performance considerations
  • •Security concerns
  • •Comment quality

Use CLAUDE.md for project-specific guidance.

Severity Levels

Critical (Must Fix)

  • •Security vulnerabilities (hardcoded credentials, SQL injection, XSS, missing input validation)
  • •Null pointer / missing null checks
  • •Resource leaks (unclosed connections, file handles)

High (Code Quality)

  • •Large functions (> 50 lines)
  • •Deep nesting (> 4 levels)
  • •Missing error handling
  • •Absent test coverage

Medium (Performance & Best Practices)

  • •Inefficient algorithms, N+1 queries
  • •Poor variable naming
  • •Missing documentation
  • •Inappropriate comments (design rationale, LLM traces)

Fix Guidelines

  • •Fix security issues (remove hardcoded credentials, add input validation)
  • •Add null checks and error handling where missing
  • •Close unclosed resources (connections, file handles)
  • •Remove inappropriate comments (design rationale, LLM traces, etc.)