AgentSkillsCN

reviewing-code

提供简明而专注的代码评审,精准匹配任务复杂度的要求。适用于代码质量审查、安全评估,或当用户请求代码评审时使用。

SKILL.md
--- frontmatter
name: reviewing-code
description: Provides concise, focused code reviews matching exact task complexity requirements. Use when reviewing code quality, security, or when the user asks for code review.

Code Review

Delivers focused, streamlined code reviews matching stated task requirements exactly. No over-analysis.

Python Standards

See docs/python-best-practices.md for comprehensive Python guidelines.

Workflow

  1. Read task requirements to understand expected scope
  2. VERIFY make validate was run - check that formatting/types/tests passed during development
  3. Run make validate again to confirm current state
  4. Match review depth to task complexity (simple vs complex)
  5. Validate requirements - does implementation match task scope exactly?
  6. Issue focused feedback with specific file paths and line numbers

Review Strategy

Simple Tasks (100-200 lines): Security, compliance, requirements match, basic quality

Complex Tasks (500+ lines): Above plus architecture, performance, comprehensive testing

Always: Use existing project patterns, immediate use after implementation

Review Checklist

Security & Compliance:

  • No security vulnerabilities (injection, XSS, etc.)
  • Follows @AGENTS.md mandatory requirements
  • MANDATORY: Passes make validate (run it now if not already done)
  • Validation was run incrementally during development (not just at the end)
  • Cognitive complexity within limits (complexipy passes)

Requirements Match:

  • Implements exactly what was requested
  • No over-engineering or scope creep
  • Appropriate complexity level

Code Quality:

  • Follows project patterns in src/
  • Proper type hints and docstrings
  • Tests cover stated functionality

Output Standards

Simple Tasks: CRITICAL issues only, clear approval when requirements met Complex Tasks: CRITICAL/WARNINGS/SUGGESTIONS with specific fixes All reviews: Concise, streamlined, no unnecessary complexity analysis