Review Changes

Run all applicable validators against recent changes and report findings.

Step 2 (rule injection) is mandatory and must complete before validation.

Step 1: Identify what changed

Get changed files. Try in order until one succeeds:

bash

# 1. Committed changes (most common)
git diff HEAD~1 --name-only --diff-filter=ACMRT

# 2. Staged changes (pre-commit)
git diff --cached --name-only --diff-filter=ACMRT

# 3. Unstaged changes (working directory)
git diff --name-only --diff-filter=ACMRT

The --diff-filter=ACMRT includes Added, Copied, Modified, Renamed, Type-changed (excludes Deleted).

Collect the list of changed files and their directories.

Step 2: Inject applicable rules

For each changed file, walk upward from its directory to repo root, collecting .claude/CLAUDE.md files:

code

For a file in backend/app/handlers/:
  Check: backend/app/handlers/.claude/CLAUDE.md
  Check: backend/app/.claude/CLAUDE.md
  Check: backend/.claude/CLAUDE.md
  Check: .claude/CLAUDE.md (root)

Use the Read tool to check each path. Collect and read those that exist. De-duplicate (a rule file only needs to be read once even if multiple files share it).

Precedence: Most specific rules override more general rules.

If two rules conflict and precedence is unclear, prefer the more specific rule and note the conflict in the report.

Record which rule files were loaded.

Step 2a: Check for local supplements

Also check for local supplements at the repo root:

bash

[[ -f .claude/local/CLAUDE.md ]] && echo "local-supplements:exists"

If .claude/local/CLAUDE.md exists, read it. Local supplements may contain custom validation commands that override the defaults.

Step 3: Run deterministic checks

Check rules for custom validation commands first: Look for a "Validation Commands" section in the loaded rules (from Step 2 and Step 2a). This section contains project-specific lint/test commands that override the defaults below.

Priority order: See claude-md/universal/validation-precedence.md for the canonical precedence rules. In short: local supplements > subdirectory rules > root rules > built-in defaults. Local supplements have the highest priority to allow per-machine customization without modifying version-controlled rules.

If no custom commands found, use these defaults based on file types:

Go:

bash

golangci-lint run -v 2>&1 | tail -50

Python:

bash

uv run pre-commit run --all-files 2>&1 | tail -50

TypeScript:

bash

pnpm run lint 2>&1 | tail -50
# or: npx biome check . 2>&1 | tail -50

Report linter results. If linters fail, report and stop - fix these first.

Step 4: Run semantic validators

Use the Task tool to spawn validators in parallel based on what changed:

Always run:

•validate-security

If Go files changed (.go):

•validate-go-effective
•validate-go-proverbs

If Python files changed (.py):

•validate-python-style

If TypeScript files changed (.ts, .tsx):

•validate-typescript-style

Collect all results.

Step 5: Aggregate and report

code

## Review Results

### Rules Applied
- backend/.claude/CLAUDE.md
- .claude/CLAUDE.md

### Files Changed
- cmd/main.go
- internal/service/handler.go
- internal/service/handler_test.go

### Linting
✓ golangci-lint passed

### Security Validation
✓ passed (no HARD, no unexplained SHOULD)

### Go Effective Validation
✗ FAILED (1 HARD, 1 SHOULD unexplained)

**HARD violations (must fix):**
1. handler.go:45 - Exported function `ProcessRequest` missing doc comment

**SHOULD violations (fix or justify):**
1. handler.go:78 - Function has 6 parameters (>5 requires justification)

**Warnings:**
1. handler.go:120 - Complex function, consider breaking up

### Summary
- Rules applied: 2
- Hard violations: 1
- Should violations: 1 (0 justified)
- Warnings: 1

### Recommended Actions
1. Add doc comment to ProcessRequest
2. Consider using options pattern for ProcessRequest parameters

Rules

•Step 2 (rule injection) is mandatory. Do NOT skip it.
•Report ALL findings, don't summarize away details.
•Be specific with file:line locations.
•Clearly separate HARD/SHOULD/WARN severity.
•Note any rule conflicts encountered.
•If everything passes, say so clearly.