AgentSkillsCN

PR Review Skill

PR评审技能

SKILL.md
<!-- Template from Agentic Academy Full course: https://agentic-academy.dev/training/claude-code Created by Silvio Gobet | youtube.com/@silviogobet -->

name: pr-review description: Thoroughly review pull requests for quality, security, and best practices

PR Review Skill

Review Checklist

Code Quality

  • • Code is readable and well-organized
  • • Functions are small and focused
  • • No code duplication
  • • Appropriate comments where needed

Logic & Correctness

  • • Logic is correct
  • • Edge cases handled
  • • Error handling present
  • • No obvious bugs

Security

  • • No secrets in code
  • • Input validation present
  • • SQL injection prevention
  • • XSS prevention (if applicable)

Performance

  • • No N+1 queries
  • • Appropriate caching
  • • No memory leaks
  • • Efficient algorithms

Testing

  • • Tests added for new code
  • • Tests pass
  • • Edge cases covered
  • • Mocks used appropriately

Documentation

  • • README updated if needed
  • • API docs updated
  • • Types documented

Output Format

Provide feedback in this format:

markdown
## Summary
[Brief overview of changes]

## Critical Issues (Must Fix)
- Issue 1
- Issue 2

## Suggestions (Should Consider)
- Suggestion 1
- Suggestion 2

## Good Practices Observed
- Practice 1
- Practice 2

## Verdict: Approved / Changes Requested