AgentSkillsCN

ai-factory.review

对暂存的更改或拉取请求进行代码评审。检查是否存在 Bug、安全漏洞、性能问题，以及是否符合最佳实践。适用于用户说“review code”、“check my code”、“review PR”或“is this code okay”时使用。

SKILL.md
--- frontmatter
name: ai-factory.review
description: Perform code review on staged changes or a pull request. Checks for bugs, security issues, performance problems, and best practices. Use when user says "review code", "check my code", "review PR", or "is this code okay".
argument-hint: [PR number or empty]
allowed-tools: Bash(git *) Bash(gh *) Read Glob Grep

Code Review Assistant

Perform thorough code reviews focusing on correctness, security, performance, and maintainability.

Behavior

Without Arguments (Review Staged Changes)

  1. •Run git diff --cached to get staged changes
  2. •If nothing staged, run git diff for unstaged changes
  3. •Analyze each file's changes

With PR Number/URL

  1. •Use gh pr view <number> --json to get PR details
  2. •Use gh pr diff <number> to get the diff
  3. •Review all changes in the PR

Review Checklist

Correctness

  • • Logic errors or bugs
  • • Edge cases handling
  • • Null/undefined checks
  • • Error handling completeness
  • • Type safety (if applicable)

Security

  • • SQL injection vulnerabilities
  • • XSS vulnerabilities
  • • Command injection
  • • Sensitive data exposure
  • • Authentication/authorization issues
  • • CSRF protection
  • • Input validation

Performance

  • • N+1 query problems
  • • Unnecessary re-renders (React)
  • • Memory leaks
  • • Inefficient algorithms
  • • Missing indexes (database)
  • • Large payload sizes

Best Practices

  • • Code duplication
  • • Dead code
  • • Magic numbers/strings
  • • Proper naming conventions
  • • SOLID principles
  • • DRY principle

Testing

  • • Test coverage for new code
  • • Edge cases tested
  • • Mocking appropriateness

Output Format

markdown
## Code Review Summary

**Files Reviewed:** [count]
**Risk Level:** 🟢 Low / 🟡 Medium / 🔴 High

### Critical Issues
[Must be fixed before merge]

### Suggestions
[Nice to have improvements]

### Questions
[Clarifications needed]

### Positive Notes
[Good patterns observed]

Review Style

  • •Be constructive, not critical
  • •Explain the "why" behind suggestions
  • •Provide code examples when helpful
  • •Acknowledge good code
  • •Prioritize feedback by importance
  • •Ask questions instead of making assumptions

Examples

User: /review Review staged changes in current repository.

User: /review 123 Review PR #123 using GitHub CLI.

User: /review https://github.com/org/repo/pull/123 Review PR from URL.

Integration

If GitHub MCP is configured, can:

  • •Post review comments directly to PR
  • •Request changes or approve
  • •Add labels based on review outcome