AgentSkillsCN

process-reviewer-feedback

通过交互式澄清功能,将自由形式的评审笔记转化为结构化的反馈格式。

SKILL.md
--- frontmatter
name: process-reviewer-feedback
description: Convert free-form reviewer notes to structured feedback format with interactive clarification.

Process Reviewer Feedback

Convert human reviewer's free-form notes into structured feedback format, clarifying unclear items through discussion.

Prerequisites

  • .claude/reviewer-notes.md must exist with reviewer's feedback

Workflow

Step 1: Read Input

  1. Read .claude/reviewer-notes.md
  2. If not found, display error:
    code
    Error: `.claude/reviewer-notes.md` not found.
    
    Run `/init-reviewer-notes` to create the template, then fill in your feedback.
    

Step 2: Analyze & Identify Issues

  1. Parse free-form text into distinct concerns
  2. For each concern, identify:
    • Referenced file/line (or mark as "TBD" if not specified)
    • Apparent severity (infer from language: "critical", "should", "might", etc.)
    • Core issue description
    • Any suggested fix mentioned

Step 3: Clarify Unclear Items

For each concern that lacks clarity, use AskUserQuestion to clarify.

When to ask:

  • File location unknown or ambiguous
  • Severity unclear
  • Expected behavior not specified
  • Scope of concern unclear

Question types:

  1. File location (when file not specified):

    code
    Question: "Which file is this concern about: '<concern summary>'?"
    Options: [List 2-4 likely files from codebase, based on concern context]
    
  2. Severity (when unclear):

    code
    Question: "How critical is: '<concern summary>'?"
    Options:
    - "Blocking - must fix before merge"
    - "Important - should fix soon"
    - "Nit - nice to have"
    - "Suggestion - consider for future"
    
  3. Expected behavior (when fix unclear):

    code
    Question: "What should happen instead for: '<concern summary>'?"
    Options: [2-4 reasonable alternatives based on context]
    
  4. Questions requiring investigation (when reviewer asks a question):

    code
    Question: "Reviewer asked: '<question>'. What would you like to do?"
    Options:
    - "Investigate now - search codebase and report findings"
    - "Skip - leave as open question"
    - "I know the answer" (use Other to provide)
    

Important:

  • Reviewer can always select "Other" to provide custom answer
  • Try to infer from context first before asking
  • Batch related questions when possible (up to 4 per AskUserQuestion)

Step 3a: Handle Investigation Requests

When user selects "Investigate now":

  1. Perform investigation:

    • Search codebase for relevant code using Grep/Glob
    • Read related files to understand current behavior
    • Check for existing tests, comments, or documentation
  2. Report findings:

    code
    Investigation: <original question>
    
    Findings:
    - <key finding 1>
    - <key finding 2>
    - ...
    
    Relevant files:
    - `<file:line>` - <what it shows>
    
  3. Ask follow-up:

    code
    Question: "Based on findings, how should we handle: '<concern>'?"
    Options:
    - "Add as blocking issue"
    - "Add as important issue"
    - "Not an issue - remove from list"
    - "Need more investigation" (specify in Other)
    
  4. Record outcome in structured feedback based on user's decision

Step 4: Structure Output

Write structured feedback to .claude/reviewer-feedback.md:

markdown
# Reviewer Feedback

Processed from: reviewer-notes.md
Date: <current date>

## Items

### 🔴 Blocking

#### 1. `<file:line>` - <title>
- **Issue:** <description>
- **Suggestion:** <recommendation or "Reviewer to advise">

### 🟡 Important

#### 1. `<file:line>` - <title>
- **Issue:** <description>
- **Suggestion:** <recommendation or "Reviewer to advise">

### 🟢 Nit

#### 1. `<file:line>` - <title>
- **Issue:** <description>
- **Suggestion:** <recommendation or "Reviewer to advise">

### 💡 Suggestions

#### 1. `<file:line>` - <title>
- **Issue:** <description>
- **Suggestion:** <recommendation or "Reviewer to advise">

Notes:

  • Use TBD for file/line if still unknown after clarification
  • Omit empty priority sections
  • Do NOT commit this file (intermediate output)

Step 5: Summary

Display summary to reviewer:

markdown
## Processed Reviewer Feedback

**Items identified:** <count>
- 🔴 Blocking: <count>
- 🟡 Important: <count>
- 🟢 Nit: <count>
- 💡 Suggestions: <count>

**Output:** `.claude/reviewer-feedback.md`

**Next step:** Run `/code-review` to generate AI review and merge with your feedback.

Step 6: Capture Knowledge

Check for new knowledge to capture from the review session.

Sources to check:

  1. Context section in reviewer-notes.md - background info, business logic, domain explanations
  2. Discussion outcomes - clarifications, investigations, and answers provided during Steps 3-3a
  3. Domain terms or abbreviations - any terminology explained during the session

When to trigger:

  • Context section has non-placeholder content (not just the template example)
  • User provided explanations during clarification that reveal business logic
  • Investigations uncovered undocumented patterns or behaviors

Action: Delegate to the learning-capture agent with a summary of potential knowledge:

code
Capture knowledge from code review session:

Context from reviewer-notes.md:
<content from Context section>

Clarifications from discussion:
<summary of explanations provided during Q&A>

Investigation findings:
<key discoveries from Step 3a investigations>

Skip if:

  • Context section is empty or contains only template placeholders
  • No substantive clarifications were needed
  • All information is already documented

Output Files

  • .claude/reviewer-feedback.md - Structured feedback (NOT committed)