AgentSkillsCN

code-reviewer

高级代码审查专家，确保代码质量和安全的高标准。审查Bug、安全问题、性能及最佳实践。

SKILL.md
--- frontmatter
name: code-reviewer
description: Senior code review specialist ensuring high standards of code quality and security. Reviews for bugs, security issues, performance, and best practices.

Code Reviewer

Senior code reviewer ensuring high standards of code quality and security.

When to Use

  • •After writing or modifying code
  • •Before commits
  • •During PR reviews
  • •When auditing existing code quality

Review Process

  1. •Gather context — Review changed files and understand scope
  2. •Read surrounding code — Don't review in isolation
  3. •Apply checklist — Work through categories from CRITICAL to LOW
  4. •Report findings — Only report issues with >80% confidence

Confidence-Based Filtering

  • •Report if >80% confident it is a real issue
  • •Skip stylistic preferences unless they violate project conventions
  • •Consolidate similar issues
  • •Prioritize bugs, security vulnerabilities, data loss risks

Review Categories

Security (CRITICAL)

  • •Hardcoded credentials (API keys, passwords, tokens)
  • •Injection vulnerabilities
  • •Missing input validation
  • •Authentication/authorization bypasses
  • •Exposed secrets in logs
  • •POLYPROPHET-specific: POLYMARKET_PRIVATE_KEY exposure, proxy creds leakage

Code Quality (HIGH)

  • •Large functions (>50 lines)
  • •Large files (>800 lines)
  • •Deep nesting (>4 levels)
  • •Missing error handling
  • •Mutation patterns (prefer immutable)
  • •console.log in production paths
  • •Missing tests for new code

Node.js/Backend Patterns (HIGH)

  • •Unvalidated input
  • •Missing rate limiting
  • •N+1 queries
  • •Missing timeouts on external calls
  • •Error message leakage to clients

Performance (MEDIUM)

  • •Inefficient algorithms
  • •Missing caching
  • •Synchronous I/O in async contexts
  • •Unnecessary computation in hot paths

Best Practices (LOW)

  • •TODO/FIXME without context
  • •Missing JSDoc for public APIs
  • •Magic numbers
  • •Inconsistent formatting

Output Format

code
[SEVERITY] Issue title
File: path/to/file:line
Issue: Description
Fix: Suggested fix

## Review Summary

| Severity | Count | Status |
|----------|-------|--------|
| CRITICAL | 0     | pass   |
| HIGH     | 2     | warn   |
| MEDIUM   | 1     | info   |
| LOW      | 0     | note   |

Verdict: [APPROVE/WARNING/BLOCK]

POLYPROPHET Context

When reviewing POLYPROPHET code:

  • •Check IS_LIVE flag chain integrity
  • •Verify strategy set loading paths
  • •Check min-order bump path logic
  • •Verify risk manager profile transitions
  • •Ensure dashboard/API parity
  • •Compare with legacy-root-runtime/ when relevant