AgentSkillsCN

requesting-code-review

当您在当前会话中执行包含独立任务的实施计划时，可选用此技能。为每个任务分配新的子代理，并进行两阶段审查。当您执行包含独立任务的实施计划时，可选用此技能——为每个任务分配新的子代理，并进行两阶段审查（先明确需求，再检验质量）。

SKILL.md
--- frontmatter
name: requesting-code-review
display_name: 请求代码审查
version: 1.0.0
author: system
description: "完成任务、实现主要功能或合并前使用，验证工作是否满足要求。Use when completing tasks, implementing major features, or before merging to verify work meets requirements. Review early, review often."
tags: [code-review, review, request, 代码审查, 请求审查, merge, 合并, quality, 质量]
allowed_tools: []
max_iterations: 15
timeout: 300
enabled: true
match_threshold: 0.70
priority: 6

Requesting Code Review

Dispatch superpowers:code-reviewer subagent to catch issues before they cascade.

Core principle: Review early, review often.

When to Request Review

Mandatory:

  • •After each task in subagent-driven development
  • •After completing major feature
  • •Before merge to main

Optional but valuable:

  • •When stuck (fresh perspective)
  • •Before refactoring (baseline check)
  • •After fixing complex bug

How to Request

1. Get git SHAs:

bash
BASE_SHA=$(git rev-parse HEAD~1)  # or origin/main
HEAD_SHA=$(git rev-parse HEAD)

2. Dispatch code-reviewer subagent:

Use Task tool with superpowers:code-reviewer type, fill template at code-reviewer.md

Placeholders:

  • •{WHAT_WAS_IMPLEMENTED} - What you just built
  • •{PLAN_OR_REQUIREMENTS} - What it should do
  • •{BASE_SHA} - Starting commit
  • •{HEAD_SHA} - Ending commit
  • •{DESCRIPTION} - Brief summary

3. Act on feedback:

  • •Fix Critical issues immediately
  • •Fix Important issues before proceeding
  • •Note Minor issues for later
  • •Push back if reviewer is wrong (with reasoning)

Example

code
[Just completed Task 2: Add verification function]

You: Let me request code review before proceeding.

BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
HEAD_SHA=$(git rev-parse HEAD)

[Dispatch superpowers:code-reviewer subagent]
  WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
  PLAN_OR_REQUIREMENTS: Task 2 from docs/plans/deployment-plan.md
  BASE_SHA: a7981ec
  HEAD_SHA: 3df7661
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types

[Subagent returns]:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

You: [Fix progress indicators]
[Continue to Task 3]

Integration with Workflows

Subagent-Driven Development:

  • •Review after EACH task
  • •Catch issues before they compound
  • •Fix before moving to next task

Executing Plans:

  • •Review after each batch (3 tasks)
  • •Get feedback, apply, continue

Ad-Hoc Development:

  • •Review before merge
  • •Review when stuck

Red Flags

Never:

  • •Skip review because "it's simple"
  • •Ignore Critical issues
  • •Proceed with unfixed Important issues
  • •Argue with valid technical feedback

If reviewer wrong:

  • •Push back with technical reasoning
  • •Show code/tests that prove it works
  • •Request clarification

See template at: requesting-code-review/code-reviewer.md