Code Review
Systematically review code for quality, bugs, and security.
Checklist
| Priority | Check |
|---|---|
| 🔴 Critical | Security (no secrets, injection) |
| 🔴 Critical | Correctness (logic, edge cases) |
| 🟡 Important | Performance (N+1, loops) |
| 🟡 Important | Error handling |
| 🟢 Nice-to-have | Readability, DRY, style |
Process
- •Context - Read requirement/design
- •High-level - Architecture check
- •Line-by-line - Detailed inspection
- •Tests - Check coverage
- •Document - Summarize findings
Output Format
markdown
## Code Review: [Name] ### Summary [Approved / Changes Requested] ### Issues - 🔴 [file:line] Problem → Suggestion - 🟡 [file:line] Problem → Suggestion ### Good Patterns 👍 - [What was done well]
Common Issues
python
# 🔴 Security
password = "hardcoded" # Bad
password = os.environ["PASS"] # Good
# 🔴 SQL Injection
f"SELECT * WHERE id={id}" # Bad
"SELECT * WHERE id=%s", (id,) # Good
Tips
- •Be constructive
- •Explain the "why"
- •Acknowledge good patterns