AgentSkillsCN

review

全面覆盖 UI、架构、数据层、质量和风格的代码评审。当您需要评审 PR、代码变更，或被要求对代码进行审查时，可运用此技能。

SKILL.md
--- frontmatter
name: review
description: Comprehensive code review covering UI, architecture, data layer, quality, and style. Use when reviewing PRs, code changes, or when asked to review code.
argument-hint: "[focus] [files] - e.g., 'ui', 'data src/...', or blank for auto"
context: fork
agent: Explore
allowed-tools: Read, Glob, Grep, Bash(git diff*, git log*, git show*, git status)

Code Review

Code review with automatic scope detection or explicit focus areas.

Usage

code
/review                           # Auto-detect scope from staged changes
/review src/main/.../MyFile.kt    # Review specific file (auto-detect focus)
/review ui                        # Focus on UI checklist only
/review data domain               # Focus on data and domain checklists
/review architecture MyModel.kt   # Architecture review of specific file

Focus Areas

When a focus is specified, apply only those checklists:

FocusDescription
uiCompose, accessibility, UX
domainUse cases, business logic
dataRepositories, SQLDelight, Ktorfit
architectureMVI/VICE patterns
qualityTesting, performance, security
styleKotlin conventions, formatting
docsKDoc, comments

Multiple focus areas can be combined: /review ui architecture

Process

  1. •Parse arguments - identify focus areas and files/commits
  2. •Identify changes using git diff or specified files
  3. •Determine scope - use explicit focus or auto-detect from file patterns
  4. •Apply checklists for each relevant area
  5. •Synthesize findings into prioritized, actionable feedback
  6. •Acknowledge good work alongside areas for improvement

Auto-Detection (when no focus specified)

File PatternReview Areas
**/screens/**, **/*View.kt, **/ui/**UI, Architecture
**/*Model.kt, **/*Compositor.ktArchitecture, Quality
**/data/**, **/repository/**, *.sqData, Quality
**/domain/**, **/usecase/**Domain, Architecture
*.kt (any)Style, Quality

Output Format

markdown
## Summary
[1-2 sentence overview of changes and overall impression]

## Review by Area

### [Area Name]
[Key findings from that area's checklist]

## Priority Issues

### 🔴 Blocking (must fix before merge)
- Issue with file:line reference

### 🟡 Important (should address)
- Issue with file:line reference

### 🔵 Suggestions (nice to have)
- Suggestion with context

## Positive Feedback
- Specific things done well

## Recommendations
1. Top priority action
2. Important follow-up

Review Philosophy

  • •Constructive: Focus on helping, not criticizing
  • •Specific: Provide file:line references and concrete suggestions
  • •Educational: Explain reasoning and link to documentation
  • •Balanced: Acknowledge good work alongside issues
  • •Prioritized: Distinguish blocking issues from suggestions

Documentation