AgentSkillsCN

urlsession-code-review

审查iOS/macOS上的URLSession网络代码。涵盖async/await模式、请求构建、错误处理、缓存及后台会话。

SKILL.md
--- frontmatter
name: urlsession-code-review
description: Reviews URLSession networking code for iOS/macOS. Covers async/await patterns, request building, error handling, caching, and background sessions.
triggers:
  - URLSession
  - URLRequest
  - URLCache
  - URLError
  - iOS networking

URLSession Code Review

Quick Reference

TopicReference
Async/Awaitasync-networking.md
Requestsrequest-building.md
Errorserror-handling.md
Cachingcaching.md

Review Checklist

Response Validation

  • • HTTP status codes validated - URLSession does NOT throw on 404/500
  • • Response cast to HTTPURLResponse before checking status
  • • Both transport errors (URLError) and HTTP errors handled

Memory & Resources

  • • Downloaded files moved/deleted (async API doesn't auto-delete)
  • • Sessions with delegates call finishTasksAndInvalidate()
  • • Long-running tasks use [weak self]
  • • Stored Task references cancelled when appropriate

Configuration

  • • timeoutIntervalForResource set (default is 7 days!)
  • • URLCache sized adequately (default 512KB too small)
  • • Sessions reused for connection pooling

Background Sessions

  • • Unique identifier (especially with app extensions)
  • • File-based uploads (not data-based)
  • • Delegate methods used (not completion handlers)

Security

  • • No hardcoded secrets (use Keychain)
  • • Header values sanitized for CRLF injection
  • • Query params via URLComponents (not string concat)

Output Format

markdown
### Critical
1. [FILE:LINE] Missing HTTP status validation
   - Issue: 404/500 responses not treated as errors
   - Fix: Check `httpResponse.statusCode` is 200-299