AgentSkillsCN

healthkit-code-review

审查HealthKit代码，重点关注授权模式、查询使用、后台推送及数据类型处理。适用于审查引入HealthKit、HKHealthStore、HKSampleQuery、HKObserverQuery或HKQuantityType的代码时。

SKILL.md
--- frontmatter
name: healthkit-code-review
description: Reviews HealthKit code for authorization patterns, query usage, background delivery, and data type handling. Use when reviewing code with import HealthKit, HKHealthStore, HKSampleQuery, HKObserverQuery, or HKQuantityType.

HealthKit Code Review

Quick Reference

Issue TypeReference
HKHealthStore, permissions, status checks, privacyreferences/authorization.md
HKQuery types, predicates, anchored queries, statisticsreferences/queries.md
Background delivery, observer queries, completion handlersreferences/background.md
HKQuantityType, HKCategoryType, workouts, unitsreferences/data-types.md

Review Checklist

  • • HKHealthStore.isHealthDataAvailable() called before any HealthKit operations
  • • Authorization requested only for needed data types (minimal permissions)
  • • requestAuthorization completion handler not misinterpreted as permission granted
  • • No attempt to determine read permission status (privacy by design)
  • • Query results dispatched to main thread for UI updates
  • • HKObjectQueryNoLimit used only with bounded predicates
  • • HKStatisticsQuery used for aggregations instead of manual summing
  • • Observer query completionHandler() always called (use defer)
  • • Background delivery registered in application(_:didFinishLaunchingWithOptions:)
  • • Background delivery entitlement added (iOS 15+)
  • • Correct units used for quantity types (e.g., count/min for heart rate)
  • • Long-running queries stored as properties and stopped in deinit

When to Load References

  • •Reviewing authorization/permissions flow -> authorization.md
  • •Reviewing HKSampleQuery, HKAnchoredObjectQuery, or predicates -> queries.md
  • •Reviewing HKObserverQuery or enableBackgroundDelivery -> background.md
  • •Reviewing HKQuantityType, HKCategoryType, or HKWorkout -> data-types.md

Review Questions

  1. •Is isHealthDataAvailable() checked before creating HKHealthStore?
  2. •Does the code gracefully handle denied permissions (empty results)?
  3. •Are observer query completion handlers called in all code paths?
  4. •Is work in background handlers minimal (~15 second limit)?
  5. •Are HKQueryAnchors persisted per sample type (not shared)?