AgentSkillsCN

ios-code-review

审查 iOS 代码，确保其符合各项标准、非功能性需求（NFR）以及安全策略。

SKILL.md
--- frontmatter
name: ios-code-review
description: Review iOS code for compliance with standards, NFRs, and security policy.
argument-hint: "[--paths <glob>] [--no-fix]"
disable-model-invocation: true
allowed-tools: Bash, Read, Glob, Grep, Write

Purpose

Review code against ios-std, ios-nfr, and ios-sec policies. Report issues, then (with approval) fix and run tests to confirm.

Arguments

  • •--paths <glob> — Limit review scope (default: whole repo)
  • •--no-fix — Report only, don't offer to fix

Workflow

1. Automated gates

bash
./scripts/lint.sh      # SwiftLint
./scripts/format.sh    # SwiftFormat (check mode)

If scripts don't exist, note that repo doesn't match scaffold expectations.

2. Policy review

Review against:

  • •ios-std — MVVM boundaries, SwiftUI conventions, project structure
  • •ios-nfr — performance, accessibility, offline correctness, app store readiness
  • •ios-sec — keychain usage, ATS, deep link validation, logging hygiene

For each issue, note:

  • •Category: std | nfr | sec
  • •Severity: must-fix | should-fix | nice-to-have
  • •File and location
  • •What's wrong and how to fix it

3. Report results

Summary of automated gate results + policy findings grouped by severity.

4–5. Approval gate, fix and confirm

See /shared-review-workflow for severity definitions, approval gate protocol, and fix constraints. Run /ios-unit-test to confirm no regressions after fixes.

Reference

For review checklists and common issues, see reference/ios-code-review-reference.md