AgentSkillsCN

sp-request-code-review

在各项任务之间以及合并前请求代码评审。利用git SHA限定变更范围,产出可操作的成果。

SKILL.md
--- frontmatter
name: sp-request-code-review
description: "Request review between tasks and before merge. Use git SHAs to scope changes and produce actionable findings."

Superpowers: Requesting Code Review (Crush Adaptation)

Based on obra/superpowers requesting-code-review skill. (MIT)
Upstream reference: skills/requesting-code-review/SKILL.md

When

  • After each task (especially in sp-subagent-dev)
  • Before merge / PR
  • When stuck

How

  1. Determine diff range (example):
bash
BASE_SHA=$(git rev-parse HEAD~1)
HEAD_SHA=$(git rev-parse HEAD)
git diff --stat "$BASE_SHA..$HEAD_SHA"
  1. Review along two axes:
  • Spec compliance: matches plan/requirements, no extra scope
  • Code quality: tests, readability, error handling, security
  1. Severity labels: Critical / Important / Minor
  • Fix Critical immediately
  • Fix Important before proceeding