Review

Overview

Perform comprehensive validation of code changes including tests, build verification, code review, and plan compliance to ensure implementation quality before deployment.

Arguments

Definitions

• •[plan-file] (optional): Plan file to verify compliance against.
• •[autofix-levels] (optional): Comma-separated list of severity levels to auto-fix (e.g., "critical,major").
• •[--skip-tests] (optional): Skip test execution.
• •[--skip-build] (optional): Skip build verification.
• •[--skip-review] (optional): Skip code review.
• •[context] (optional): Freeform context for validation focus.

Values

$ARGUMENTS

Core Principles

• •All validation types run by default unless explicitly skipped
• •Findings are rated by criticality for proper prioritization
• •Auto-fix only applies to programmatically fixable issues
• •Plan compliance checks verify requirements are met
• •Re-run validation after auto-fix to confirm all issues resolved
• •Fix failed tests before proceeding
• •Understand what will be changed before using auto-fix
• •Verify each requirement explicitly - never assume plan compliance
• •Resolve all critical and major issues before deployment

Skill-Specific Guidelines

Auto-Fix Behavior

When --autofix is specified:

1. •Parse the comma-separated severity levels
2. •After completing all validation, identify fixable issues
3. •For each fixable issue at the specified severity levels:
   • •Describe the fix to be applied
   • •Apply the fix
   • •Mark as fixed in the report
4. •Re-run affected validations to confirm fixes

Example:

--autofix critical,major  # Auto-fix critical and major issues
--autofix critical        # Auto-fix only critical issues

Test Framework Detection

Build System Detection

Instructions

Perform ALL validation types (unless skipped):

1. Run Tests

• •Detect test framework from project files:
  • •package.json with test script: npm test
  • •pytest.ini, pyproject.toml with pytest: pytest
  • •Cargo.toml: cargo test
  • •go.mod: go test ./...
  • •Makefile with test target: make test
• •Execute test suite
• •Report failures with details
• •Categorize test failures by severity

2. Code Review

• •Launch code-reviewer agent on changed files
• •Check for:
  • •Bugs and logic errors
  • •Security vulnerabilities
  • •Code quality issues
  • •Missing error handling
  • •Performance concerns
• •Review against project conventions (from CLAUDE.md)
• •Rate findings by criticality:
  • •Critical: Security vulnerabilities, data loss risks
  • •Major: Bugs, logic errors, significant quality issues
  • •Medium: Code quality, maintainability concerns
  • •Low: Style issues, minor improvements

3. Build Verification

• •Detect build system from project files:
  • •package.json with build script: npm run build
  • •Cargo.toml: cargo build
  • •go.mod: go build ./...
  • •Makefile with build target: make build
  • •pyproject.toml: uv build
• •Execute build process
• •Report build errors with details

4. Plan Compliance (if --plan provided)

• •Read and parse the plan file
• •Extract requirements and tasks
• •Verify each requirement is implemented:
  • •Check for expected files/components
  • •Verify functionality matches requirements
  • •Check validation criteria from plan
• •Generate compliance report:
  • •Completed requirements
  • •Missing or incomplete items
  • •Deviations from plan

Output Guidance

Generate a comprehensive validation report using the structure defined in the Templates section. Present results clearly with:

• •Summary statistics for each validation type
• •Detailed findings grouped by severity
• •Actionable recommendations for fixing issues
• •Plan compliance status (if plan provided)

Templates

Validation Report Structure

# Validation Report

<!--
Instructions:
- Generate this report after completing all validation steps
- Include all sections, even if results are empty
-->

## Summary

- Tests: {{test_status}} ({{passed_count}} passed, {{failed_count}} failed)
- Build: {{build_status}}
- Code Review: {{critical_count}} critical, {{major_count}} major, {{medium_count}} medium, {{low_count}} low
- Plan Compliance: {{compliance_percent}}% complete

<!--
Instructions:
- Replace {{test_status}} with PASS or FAIL
- Replace {{passed_count}}, {{failed_count}} with actual counts
- Replace {{build_status}} with PASS or FAIL
- Replace {{critical_count}}, {{major_count}}, {{medium_count}}, {{low_count}} with issue counts
- Replace {{compliance_percent}} with percentage (omit line if no plan provided)
-->

## Test Results

{{test_details}}

<!--
Instructions:
- Replace {{test_details}} with details of any test failures
- Include test name, expected vs actual, and error messages
- If all tests pass, write "All tests passed successfully."
-->

## Build Results

{{build_details}}

<!--
Instructions:
- Replace {{build_details}} with details of any build errors
- Include error messages and affected files
- If build succeeds, write "Build completed successfully."
-->

## Code Review Findings

### Critical

{{critical_issues}}

<!--
Instructions:
- Replace {{critical_issues}} with critical issues found
- Include file location, issue description, and suggested fix
- If none found, write "No critical issues found."
-->

### Major

{{major_issues}}

<!--
Instructions:
- Replace {{major_issues}} with major issues found
- Use same format as critical issues
- If none found, write "No major issues found."
-->

### Medium

{{medium_issues}}

<!--
Instructions:
- Replace {{medium_issues}} with medium issues found
- Use same format as critical issues
- If none found, write "No medium issues found."
-->

### Low

{{low_issues}}

<!--
Instructions:
- Replace {{low_issues}} with low severity issues found
- Use same format as critical issues
- If none found, write "No low severity issues found."
-->

## Plan Compliance

{{compliance_details}}

<!--
Instructions:
- Replace {{compliance_details}} with compliance analysis
- List completed requirements, missing items, and deviations
- Omit this section if no --plan was provided
-->

## Recommendations

{{recommendations}}

<!--
Instructions:
- Replace {{recommendations}} with prioritized next steps
- Order by severity: critical first, then major, etc.
- Include specific actions to resolve each issue
-->