SDLC Review

Overview

Review the implementation against quality standards and optionally against a plan. When a plan is provided, the review verifies plan compliance. Creates a review.md file in the specified output directory. When no plan is provided, the review examines the diff compared to the remote main branch.

Arguments

Definitions

•<workflow-id> (required): The workflow identifier for output organization.
•[plan] (optional): Path to plan document. When provided, review checks plan compliance.
•[output_dir] (optional): Directory to write review.md file (default to agentic/outputs/<workflow-id>).
•[severity] (optional): Minimum severity to report. Values: minor, major, critical. Defaults to minor.

Values

$ARGUMENTS

Core Principles

•Review all changes thoroughly before reporting
•When no plan is provided, review the diff against origin/main (or origin/master as fallback)
•When a plan is provided, verify all milestones and tasks are completed
•Report issues with accurate severity levels
•Tests, lint, types, and build must pass for a successful review
•Always create a review.md file in the output directory

Instructions

•
Parse Arguments
- •Extract workflow-id, plan, output_dir, and severity from arguments
- •Default output_dir to agentic/outputs/<workflow-id> if not specified
- •Default severity to minor if not specified
•
Determine Review Scope
- •If plan is provided: Load and parse the plan document
- •If no plan: Fetch latest remote main branch and get diff
•
Run Quality Checks
- •Test Suite: Run all tests, verify coverage
- •Linter: Check for linting errors
- •Type Checker: Verify type correctness
- •Build: Ensure project builds successfully
•
Review Changes
- •
  If plan provided:
  - •Verify all milestones completed
  - •Verify all tasks marked done
  - •Check for scope creep (unplanned changes)
- •
  If no plan:
  - •Review all changed files in the diff
  - •Check for code quality issues
  - •Identify potential bugs or regressions
•
Generate Review Output
- •Aggregate all check results
- •Filter issues by severity threshold
- •Generate summary
•
Write Outputs
- •Create review.md file in the output_dir
- •Return JSON output

Output Guidance

JSON Output

Return JSON with review details:

json

{
  "success": true,
  "review_passed": {{review_passed}},
  "checks": {
    "plan_compliance": {
      "passed": {{plan_compliance_passed}},
      "milestones_complete": {{milestones_complete}},
      "milestones_total": {{milestones_total}}
    },
    "tests": {
      "passed": {{tests_passed}},
      "total": {{tests_total}},
      "passing": {{tests_passing}},
      "failing": {{tests_failing}},
      "coverage": {{coverage_percent}}
    },
    "lint": {
      "passed": {{lint_passed}},
      "errors": {{lint_errors}},
      "warnings": {{lint_warnings}}
    },
    "types": {
      "passed": {{types_passed}},
      "errors": {{type_errors}}
    },
    "build": {
      "passed": {{build_passed}}
    }
  },
  "issues": [{{issues_array}}],
  "summary": "{{summary}}",
  "document_path": "{{document_path}}"
}

Issue Schema

json

{
  "severity": "{{severity}}",
  "category": "{{category}}",
  "message": "{{message}}",
  "file": "{{file}}",
  "line": {{line}}
}

Review Document

Create a review.md file in the output_dir with the following format:

markdown

# Review

**Status**: {{review_status}}
**Date**: {{review_date}}

## Progress

- [ ] All issues resolved
- [ ] Tests passing
- [ ] Lint passing
- [ ] Types passing
- [ ] Build passing

## Summary

{{summary}}

## Checks

| Check           | Status                     | Details                                                                    |
| --------------- | -------------------------- | -------------------------------------------------------------------------- |
| Plan Compliance | {{plan_compliance_status}} | {{milestones_complete}}/{{milestones_total}} milestones                    |
| Tests           | {{tests_status}}           | {{tests_passing}}/{{tests_total}} passing ({{coverage_percent}}% coverage) |
| Lint            | {{lint_status}}            | {{lint_errors}} errors, {{lint_warnings}} warnings                         |
| Types           | {{types_status}}           | {{type_errors}} errors                                                     |
| Build           | {{build_status}}           | {{build_details}}                                                          |

## Issues

{{#if issues_exist}}
| Severity | Category | File | Line | Message |
|----------|----------|------|------|---------|
{{#each issues}}
| {{severity}} | {{category}} | {{file}} | {{line}} | {{message}} |
{{/each}}
{{else}}
No issues found.
{{/if}}