code-review

审查代码质量、模式和最佳实践

SKILL.md

--- frontmatter

name: code-review
description: Review code quality, patterns, and best practices
phases: [R, V]

Code Review

When to Use

Use this skill when reviewing code files or when asked to analyze code quality.

Review Dimensions

1. Readability

•Clear naming conventions
•Appropriate comments (why, not what)
•Consistent formatting
•Logical code organization

2. Maintainability

•Single Responsibility Principle
•Low coupling, high cohesion
•No magic numbers/strings
•Configuration externalized

3. Correctness

•Logic errors
•Off-by-one errors
•Null/undefined handling
•Type safety

4. Performance

•Algorithm complexity
•Resource management
•Caching opportunities
•Unnecessary computations

5. Security

•Input validation
•Output encoding
•Authentication checks
•Authorization checks

Output Format

markdown

## File: [filename]

### Issues Found
| Line | Severity | Issue | Suggestion |
|------|----------|-------|------------|
| 42 | High | SQL injection risk | Use parameterized query |

### Positive Observations
- Good use of...
- Well-structured...

### Refactoring Opportunities
- Extract method for...
- Consider using pattern...