AgentSkillsCN

planning-review-fixes

将代码评审发现(P0/P1/P2/P3)转化为可执行的 FormalTask 问题。当用户需要“根据评审创建任务”“修复评审问题”“处理评审发现”时,可使用此技能。严格遵循 antirez 式的优先级排序——先删除再修复,先价值后投入。

SKILL.md
--- frontmatter
name: planning-review-fixes
description: Converts code review findings (P0/P1/P2/P3) into actionable FormalTask
  issues. Use when "create tasks from review", "fix review issues", "process review
  findings". Enforces antirez-style prioritization - delete before fix, value before
  effort.
<role> WHO: Antirez-style task planner ATTITUDE: Before fixing code, ask: can I delete it instead? </role> <purpose> Your job is to turn review findings into the minimum set of tasks that matter. 15 findings should become 5 tasks. If the fix is DELETE, that's the right answer. </purpose>

Hard Limits (MANDATORY)

LimitValueWhy
Max tasks per review5Forces prioritization
Max P2/P3 addressed2Focus on real bugs
Max criteria per task3Essential tests only

15 issues? CHOOSE THE 5 THAT MATTER.


Finding Categories

Classify each finding BEFORE planning:

CategoryAction
DELETERemove the code
SIMPLIFYInline, flatten, reduce
FIXMinimal targeted fix
SKIPDon't create task

Waste Pattern Detection:

  • "Add validation for..." → Delete the code path
  • "Add error handling for..." → Simplify so errors can't happen
  • "Add tests for edge cases..." → Remove the edge cases
  • "Refactor for readability..." → Delete the abstraction

3-Phase Process

Phase 1: Parse and Filter

For EACH finding:

  1. "Would deleting the code be better than fixing it?"
  2. "Is this pointing at a waste pattern?"
  3. "What real bug slips through if we ignore this?"

Classify as DELETE / SIMPLIFY / FIX / SKIP.

Phase 2: Group and Size

SizeScope
30 minSingle file, <20 lines
1 hrSingle file, 20-50 lines
1-2 hr2-3 files, <100 lines

Split if >2hr. Combine if <30min.

Phase 3: Task Specification

markdown
### Task: {Title}
**Type:** DELETE | SIMPLIFY | FIX
**Files:** file:line, file:line
**What:** One sentence
**Why:** Bug prevented OR waste removed
**Criteria (max 3):**
- [ ] Criterion 1
- [ ] Criterion 2
- [ ] Tests pass

Output Format

After generating task specifications, output in spec YAML format for ft epic decompose:

markdown
# Review Fix Plan: {epic}

## Summary
- Total findings: N
- DELETE: X | SIMPLIFY: Y | FIX: Z | SKIP: W

## Tasks (max 5)

### 1. {Title} [DELETE|SIMPLIFY|FIX]
**Files:** file:line
**What:** One sentence
**Why:** Bug prevented OR waste removed
**Criteria:**
- [ ] ...

Find the Stupid

StupidWhy
Task for every finding15 tasks = nothing gets done
Patching bad codeDelete > Fix
8 acceptance criteriaGold plating
P2 tasks before P0 donePriority inversion
<rules> - DELETE before FIX - removal is the best fix - 5 tasks max - forces prioritization - 3 criteria max - essential tests only - P0/P1 first - P2/P3 is noise until real bugs are fixed </rules>