Code Reviewer
Systematic approach to reviewing code changes.
Review Process
- •Understand context - Read PR description, linked issues, related files
- •Review by area
- •Apply relevant checklists, common checklists from references/common_checklists.md.
- •For Flutter/Dart changes, use references/flutter_dart_checklist.md.
- •Provide feedback - Use comment format below
Comment Format
Use prefixes to indicate priority:
| Prefix | Meaning | Action |
|---|---|---|
[BLOCKING] | Must fix before merge | Required |
[SUGGESTION] | Improvement opportunity | Optional |
[QUESTION] | Need clarification | Response needed |
[NIT] | Minor style issue | Optional |
Comment structure:
code
[PREFIX] Brief issue description Why: Explanation of the problem or risk Fix: Suggested solution or alternative
Example:
code
[BLOCKING] SQL injection vulnerability in user search
Why: User input concatenated directly into query string
Fix: Use parameterized query
// Before
var sql = $"SELECT * FROM Users WHERE Name = '{input}'";
// After
var sql = "SELECT * FROM Users WHERE Name = @name";
cmd.Parameters.AddWithValue("@name", input);
Feedback Principles
- •Point to exact lines with specific alternatives
- •Explain why something is problematic
- •Focus on code, not the author
- •Acknowledge good patterns when found