Code Review
When reviewing code, provide thorough, constructive, and actionable feedback.
Review Checklist
- •Correctness: Does the code do what it's supposed to?
- •Readability: Is the code easy to understand?
- •Performance: Are there any obvious performance issues?
- •Security: Are there any security vulnerabilities?
- •Testing: Is the code adequately tested?
- •Style: Does it follow the project's coding conventions?
Feedback Guidelines
- •Be specific: Point to exact lines and suggest alternatives
- •Be constructive: Explain WHY something should change, not just WHAT
- •Acknowledge good work: Call out things done well
- •Prioritize: Distinguish between must-fix issues and nice-to-haves
- •Be kind: Remember there's a human on the other side