AgentSkillsCN

requesting-code-review

在完成任务、实现重大功能，或在合并代码之前使用——在继续推进之前，派遣代码评审子代理依据计划或需求对实现过程进行复核。

SKILL.md
--- frontmatter
name: requesting-code-review
description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements - dispatches code-reviewer subagent to review implementation against plan or requirements before proceeding

Requesting Code Review

Dispatch superpowers:code-reviewer subagent to catch issues before they cascade.

Core principle: Review early, review often.

When to Request Review

Mandatory:

  • •After each task in subagent-driven development
  • •After completing major feature
  • •Before merge to main

Optional but valuable:

  • •When stuck (fresh perspective)
  • •Before refactoring (baseline check)
  • •After fixing complex bug

How to Request

1. Claude extracts git SHAs automatically:

When you request a review, Claude runs via Bash tool:

bash
BASE_SHA=$(git rev-parse origin/main)  # or HEAD~1, develop, etc.
HEAD_SHA=$(git rev-parse HEAD)

You can specify different base: "Review against develop" or "Review last 3 commits"

2. Claude dispatches code-reviewer subagent:

Uses Task tool with superpowers:code-reviewer type, fills template at code-reviewer.md

Placeholders Claude fills automatically:

  • •{WHAT_WAS_IMPLEMENTED} - What you just built
  • •{PLAN_OR_REQUIREMENTS} - What it should do (you provide or Claude infers)
  • •{BASE_SHA} - Starting commit (auto-extracted)
  • •{HEAD_SHA} - Ending commit (auto-extracted)
  • •{DESCRIPTION} - Brief summary (you provide or Claude generates from diff)

3. Act on feedback:

  • •Fix Critical issues immediately
  • •Fix Important issues before proceeding
  • •Note Minor issues for later
  • •Push back if reviewer is wrong (with reasoning)

Example

code
[Just completed Task 2: Add verification function]

You: Let me request code review before proceeding.

Claude: [Automatically extracts SHAs]
$ git rev-parse origin/main  # a7981ec
$ git rev-parse HEAD          # 3df7661

[Dispatches superpowers:code-reviewer subagent]
  WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
  PLAN_OR_REQUIREMENTS: Task 2 from docs/plans/deployment-plan.md
  BASE_SHA: a7981ec
  HEAD_SHA: 3df7661
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types

[Subagent returns]:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

You: [Reports findings]
You: [fix progress indicators]
[Continue to Task 3]

Integration with Workflows

Subagent-Driven Development:

  • •Review after EACH task
  • •Catch issues before they compound
  • •Fix before moving to next task

Executing Plans:

  • •Review after each batch (3 tasks)
  • •Get feedback, apply, continue

Ad-Hoc Development:

  • •Review before merge
  • •Review when stuck

Red Flags

Never:

  • •Skip review because "it's simple"
  • •Ignore Critical issues
  • •Proceed with unfixed Important issues
  • •Argue with valid technical feedback

If reviewer wrong:

  • •Push back with technical reasoning
  • •Show code/tests that prove it works
  • •Request clarification

See template at: requesting-code-review/code-reviewer.md