AgentSkillsCN

requesting-code-review

当完成各项任务、实现重大功能,或在合并代码前,为确保工作完全符合需求而使用。

SKILL.md
--- frontmatter
name: requesting-code-review
description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements

Requesting Code Review

Adapted from obra/superpowers for Cursor IDE.

Dispatch a code-reviewer subagent via Cursor's Task tool to catch issues before they cascade.

Core principle: Review early, review often.

When to Request Review

Mandatory:

  • After each task in subagent-driven development
  • After completing major feature
  • Before merge to main

Optional but valuable:

  • When stuck (fresh perspective)
  • Before refactoring (baseline check)
  • After fixing complex bug

How to Request

1. Get git SHAs:

bash
BASE_SHA=$(git rev-parse HEAD~1) # or origin/main
HEAD_SHA=$(git rev-parse HEAD)

2. Dispatch code-reviewer subagent via Cursor's Task tool:

code
description: "Code review for [feature]"
subagent_type: "generalPurpose"
readonly: true
prompt: |
  Review the code changes between {BASE_SHA} and {HEAD_SHA}.

  ## What Was Implemented
  {WHAT_WAS_IMPLEMENTED}

  ## Plan/Requirements
  {PLAN_OR_REQUIREMENTS}

  ## Review Criteria
  - Plan alignment (deviations justified?)
  - Code quality (patterns, error handling, types)
  - Architecture (SOLID, separation of concerns)
  - Test coverage and quality
  - Security and performance

  Categorize issues as:
  - **Critical** (must fix before merge)
  - **Important** (should fix before proceeding)
  - **Minor** (nice to have)

  Report: Strengths, Issues by severity, Assessment

3. Act on feedback:

  • Fix Critical issues immediately
  • Fix Important issues before proceeding
  • Note Minor issues for later
  • Push back if reviewer is wrong (with reasoning)