AgentSkillsCN

rust-review

在进行Rust专项代码审计时，请使用此技能。适用于审查Rust代码、审计unsafe代码块、分析所有权模式、扫描Cargo依赖以排查安全漏洞时使用。切勿在仅进行一般代码审查、无需Rust时使用此技能——请改用统一审查技能。切勿在需要进行性能剖析时使用此技能——请改用Parseltongue：Python性能模式。

SKILL.md
--- frontmatter
name: rust-review
description: 'Use this skill for Rust-specific code audits. Use when reviewing Rust
  code, auditing unsafe blocks, analyzing ownership patterns, scanning Cargo dependencies
  for security. Do not use when general code review without Rust - use unified-review.
  DO NOT use when: performance profiling - use parseltongue:python-performance pattern.'
category: code-review
tags:
- rust
- ownership
- concurrency
- unsafe
- traits
- cargo
tools:
- borrow-checker-analyzer
- unsafe-auditor
- dependency-scanner
usage_patterns:
- rust-audit
- unsafe-review
- dependency-audit
- concurrency-analysis
complexity: advanced
estimated_tokens: 400
progressive_loading: true
dependencies:
- pensive:shared
- imbue:evidence-logging
modules:
- ownership-analysis.md
- error-handling.md
- concurrency-patterns.md
- unsafe-audit.md
- cargo-dependencies.md
version: 1.4.0

Table of Contents

Rust Review Workflow

Expert-level Rust code audits with focus on safety, correctness, and idiomatic patterns.

Quick Start

bash
/rust-review

Verification: Run the command with --help flag to verify availability.

When To Use

  • •Reviewing Rust code changes
  • •Auditing unsafe blocks
  • •Analyzing concurrency patterns
  • •Dependency security review
  • •Performance optimization review

When NOT To Use

  • •General code review without Rust - use unified-review
  • •Performance profiling - use parseltongue:python-performance pattern

Required TodoWrite Items

  1. •rust-review:ownership-analysis
  2. •rust-review:error-handling
  3. •rust-review:concurrency
  4. •rust-review:unsafe-audit
  5. •rust-review:cargo-deps
  6. •rust-review:evidence-log

Progressive Loading

Load modules as needed based on review scope:

Quick Review (ownership + errors):

  • •See modules/ownership-analysis.md for borrowing and lifetime analysis
  • •See modules/error-handling.md for Result/Option patterns

Concurrency Focus:

  • •See modules/concurrency-patterns.md for async and sync primitives

Safety Audit:

  • •See modules/unsafe-audit.md for unsafe block documentation

Dependency Review:

  • •See modules/cargo-dependencies.md for vulnerability scanning

Core Workflow

  1. •Ownership Analysis: Check borrowing, lifetimes, clone patterns
  2. •Error Handling: Verify Result/Option usage, propagation
  3. •Concurrency: Review async patterns, sync primitives
  4. •Unsafe Audit: Document invariants, FFI contracts
  5. •Dependencies: Scan for vulnerabilities, updates
  6. •Evidence Log: Record commands and findings

Rust Quality Checklist

Safety

  • • All unsafe blocks documented with SAFETY comments
  • • FFI boundaries properly wrapped
  • • Memory safety invariants maintained

Correctness

  • • Error handling complete
  • • Concurrency patterns sound
  • • Tests cover critical paths

Performance

  • • No unnecessary allocations
  • • Borrowing preferred over cloning
  • • Async properly non-blocking

Idioms

  • • Standard traits implemented
  • • Error types well-designed
  • • Documentation complete

Output Format

markdown
## Summary
Rust audit findings

## Ownership Analysis
[borrowing and lifetime issues]

## Error Handling
[error patterns and issues]

## Concurrency
[async and sync patterns]

## Unsafe Audit
### [U1] file:line
- Invariants: [documented]
- Risk: [assessment]
- Recommendation: [action]

## Dependencies
[cargo audit results]

## Recommendation
Approve / Approve with actions / Block

Verification: Run the command with --help flag to verify availability.

Exit Criteria

  • •All unsafe blocks audited
  • •Concurrency patterns verified
  • •Dependencies scanned
  • •Evidence logged
  • •Action items assigned

Troubleshooting

Common Issues

Command not found Ensure all dependencies are installed and in PATH

Permission errors Check file permissions and run with appropriate privileges

Unexpected behavior Enable verbose logging with --verbose flag