AgentSkillsCN

reviewing

依据计划、架构、代码及政策检测缺陷,并对发现的问题进行分类,但不提出改进建议。

SKILL.md
--- frontmatter
name: reviewing
description: Detect defects against the plan, architecture, code, and policies; classify findings without proposing improvements.

Purpose

Report defects with required severity classifications and clear impact, without remediation.

Inputs

  • Artifacts under review (code, plan, architecture)
  • Applicable policies and context

Severity Levels

LevelNameDescriptionAction
P0CriticalSecurity vulnerability, data loss risk, correctness bugMust block merge
P1HighLogic error, significant SOLID violation, performance regressionShould fix before merge
P2MediumCode smell, maintainability concern, minor SOLID violationFix in this PR or create follow-up
P3LowStyle, naming, minor suggestionOptional improvement

Steps

  1. Load required context: plan, architecture, policies, and artifacts.
  2. Identify defects against requirements, policies, and correctness.
  3. Classify each finding as P0, P1, P2, or P3.
  4. Report precise locations and impacts using the required format.

Outputs

  • Markdown review in the following structure; no fixes or redesigns:
markdown
## Review Summary

**Files reviewed**: X files, Y lines changed
**Overall assessment**: [APPROVE / REQUEST_CHANGES / COMMENT]

---

## Findings

### P0 - Critical

(none or list)

### P1 - High

- **[file:line]** Brief title
  - Description of issue
  - Suggested fix

### P2 - Medium

...

### P3 - Low

...
  • If no issues, state what was checked, areas not covered, and residual risks.

Failure modes

  • Suggesting improvements or scope changes beyond defect reporting
  • Missing required P0-P3 classifications or unclear locations
  • Mixing detection with remediation