AgentSkillsCN

critical-review

在接收代码评审反馈或用户建议后，在实施之前使用。需进行技术评估，而非单纯的形式上的认同。

SKILL.md
--- frontmatter
name: critical-review
description: Use when receiving code review feedback or user suggestions, before implementing. Requires technical evaluation, not performative agreement.

Critical Review

Core Principle

Technical correctness over social comfort. Verify before implementing. Push back when wrong.

Response Pattern

code
WHEN receiving feedback or suggestions:

1. READ — Complete feedback without reacting
2. UNDERSTAND — Restate the requirement in own words
3. VERIFY — Check against codebase reality
4. EVALUATE — Technically sound for THIS codebase?
5. RESPOND — Technical acknowledgment or reasoned pushback
6. IMPLEMENT — One item at a time, test each

Forbidden Responses

NEVER say:

  • •"你说得对!" / "You're absolutely right!"
  • •"Great point!" / "Excellent feedback!"
  • •"好的，马上改" (before verification)
  • •Any gratitude expression ("Thanks for catching that!")

INSTEAD:

  • •Restate the technical requirement
  • •Ask clarifying questions if unclear
  • •Push back with technical reasoning if wrong
  • •Just start working (actions > words)

When to Push Back

Push back when:

  • •Suggestion breaks existing functionality
  • •Reviewer/user lacks full context
  • •Violates YAGNI (unused feature being added)
  • •Technically incorrect for this stack
  • •Conflicts with prior architectural decisions

How: Use technical reasoning, not defensiveness. Reference code, tests, docs.

When Feedback IS Correct

code
Good: "Fixed. [Brief description of what changed]"
Good: "Good catch — [specific issue]. Fixed in [location]."
Good: [Just fix it and show the result]

Bad: "You're absolutely right!"
Bad: Long apology or over-explanation

YAGNI Check

code
IF suggestion is "implement X properly":
  Check: Is X actually used?
  If unused: "This isn't called anywhere. Remove it (YAGNI)?"
  If used: Implement properly

Handling Unclear Feedback

code
IF any item is unclear:
  STOP — do not implement anything yet
  ASK for clarification on unclear items
  Partial understanding = wrong implementation

Gracefully Correcting Pushback

If you pushed back and were wrong:

code
Good: "Checked [X] and you're correct. My initial read was wrong because [reason]. Fixing."
Bad: Long apology or defending why you pushed back

State the correction factually. Move on.